Skip to content

sort: --files0-from should not panic when invalid utf-8 #9692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sylvestre wants to merge 3 commits into
base: main
Choose a base branch
from
Open

sort: --files0-from should not panic when invalid utf-8 #9692

sylvestre wants to merge 3 commits into from

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Dec 18, 2025

No description provided.

@sylvestre sylvestre force-pushed the sort-utf branch 2 times, most recently from 140a726 to e1837a0 Compare December 18, 2025 09:57
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

cakebaker
cakebaker reviewed Dec 18, 2025
View reviewed changes
@sylvestre sylvestre force-pushed the sort-utf branch 2 times, most recently from 57f5452 to 1c0f20e Compare December 18, 2025 17:23
@cakebaker cakebaker linked an issue Dec 18, 2025 that may be closed by this pull request
sort --files0-from Requires UTF-8 / Panics on Non‑UTF‑8 Filenames #9696
Open
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

GNU testsuite comparison:

Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/misc/nohup is no longer failing!
Note: The gnu test tests/tail/inotify-dir-recreate is now being skipped but was previously passing.

cakebaker
cakebaker reviewed Dec 19, 2025
View reviewed changes
cakebaker
cakebaker reviewed Dec 19, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 3.28%

Comparing sylvestre:sort-utf (a2c58fc) with main (20a5c3a)

Summary

⚡ 1 improved benchmark
✅ 139 untouched benchmarks
⏩ 37 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ tsort_input_parsing_heavy[5000] 73.7 ms 71.4 ms +3.28%

Footnotes

  1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sort --files0-from Requires UTF-8 / Panics on Non‑UTF‑8 Filenames

2 participants

@sylvestre @cakebaker